[webkit-reviews] review denied: [Bug 6431] REGRESSION: style change where :hover changes only an :after style doesn't work : [Attachment 6780] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 14:44:40 PST 2006


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 6431: REGRESSION: style change where :hover changes only an :after style
doesn't work
http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

Attachment 6780: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6780&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You shouldn't have to do a detach just because :before/:after content changed.

All you have to do is set the new RenderStyle, and the rest will be taken care
of by updatePseudoChild.

A change of NoInherit returned from the diff function should be sufficient to
cause the right thing to happen.



More information about the webkit-reviews mailing list