[webkit-reviews] review denied: [Bug 5860] feComponentTransfer doesn't work : [Attachment 6740] fixed formatting errors

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 12:10:11 PST 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5860: feComponentTransfer doesn't work

Attachment 6740: fixed formatting errors

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
+    return [super init];

feels wrong to me.  I think there are several advantages to calling [super
init] first and handling a nil value.  One is making sure that your parent
classes's data structures are initialized, another is to avoid work if your
parent class fails.

I guess I would suggest:
self = [super init];
if (!self)
// other goop
return self;
Maybe it's not worth it in this case... since it is a lot of extra code for
little gain.

Why? -1?
[NSNumber numberWithFloat:[inputTable extent].size.width-1.0]

Please use an enum instead of #define

+#define CHANNEL_RED   0

Otherwise looks great.	We can talk about this on IRC if you like.  With those
changes, you're welcome to land.

I think given that this is the first patch you're going to land yourself, it's
probably best to see the whole final patch with ChangeLog.  We can also just
work all that out via IRC when we're both next around.

More information about the webkit-reviews mailing list