[webkit-reviews] review requested: [Bug 3812] XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET : [Attachment 6776] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 11:05:46 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 3812: XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST
actually do a GET
http://bugzilla.opendarwin.org/show_bug.cgi?id=3812

Attachment 6776: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6776&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
There are some differences between this implementaion and Firefox:
1) For null data, "Content-Length: 0" header is sent (isn't sent in Firefox).
Looks like better behavior to me; besides, I don't think we have a choice,
because this header is added by NSURLConnection.
2) HEAD is not implemented - there seems to be a crashing bug in
NSURLConnection, <rdar://4460899>.
3) After #2 is fixed, we won't be sending a body in HEAD requests, just like we
don't send it in GET ones. Firefox ignores the body in GET requests, but sends
it in HEAD ones, which looks like a bug to me.

Also fixed a bug: send(null) was actually sending characters "null" instead of
an empty body.



More information about the webkit-reviews mailing list