[webkit-reviews] review denied: [Bug 3905] Missing </title> makes page blank : [Attachment 6773] Patch v6

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 09:38:38 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 3905: Missing </title> makes page blank

Attachment 6773: Patch v6

------- Additional Comments from Darin Adler <darin at apple.com>
I don't understand why we save lineno + src.lineCount() but then restore it
into lineno; it seems like this will make lineno higher than it should be. I'd
like to see a test that checks that the line numbers are correct. To do that
you'll have to figure out what the line numbers are used for.

I don't think the SegmentedString copy constructor should be in the header file
and the assignment operator not. Either both should be inlined or neither. I'd
lean toward neither.

Because of the line number issue, I'm going to mark this review-, but this
looks nearly perfect!

More information about the webkit-reviews mailing list