[webkit-reviews] review requested: [Bug 3905] Missing </title> makes page blank : [Attachment 6773] Patch v6

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 06:56:38 PST 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 3905: Missing </title> makes page blank

Attachment 6773: Patch v6

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Updates from Patch v5:

- Removed verbose comments from htmlparser.cpp patch.
- Added copy constructor and assignment operator to SegmentedString class.


- In the SegmentedString class, I can't find any code where "m_currentChar =
&m_pushedChar2", so I'm not sure the middle else-if logic is really necessary
in the copy constructor and assignment operator.
- I did not put the operator=() prototype next to the other operator prototypes
in SegmentedString.h.  I thought it best to leave it by the copy constructor. 
Let me know if this needs to be moved.
- All layout tests passed with this new patch.

More information about the webkit-reviews mailing list