[webkit-reviews] review granted: [Bug 3905] Missing </title> makes
page blank : [Attachment 6753] Patch v4
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Feb 27 08:26:38 PST 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 3905: Missing </title> makes page blank
http://bugzilla.opendarwin.org/show_bug.cgi?id=3905
Attachment 6753: Patch v4
http://bugzilla.opendarwin.org/attachment.cgi?id=6753&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
In htmlParser.cpp, I don't know why the check n->isHTMLElement() is
appropriate; it seems too strict. What about a non-HTML element after a <title>
like a custom tag? It seems that the code could be simpler, more like the
handling of addressTag, fontTag, dlTag, and dtTag.
I think it's OK to land the patch like this, but probably even better to
simplify it more.
r=me anyway
More information about the webkit-reviews
mailing list