[webkit-reviews] review granted: [Bug 7491] add new TextEncoding stuff to win32 build : [Attachment 6758] Add TextEncoding, plus some fixes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 27 08:19:53 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7491: add new TextEncoding stuff to win32 build
http://bugzilla.opendarwin.org/show_bug.cgi?id=7491

Attachment 6758: Add TextEncoding, plus some fixes
http://bugzilla.opendarwin.org/attachment.cgi?id=6758&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
std::min is in <algorithm>, so you should include that instead of <utility> in
StreamingTextDecoder.cpp.

It worries me that the entire WebCore.vcproj is showing up in the diff. Is
something configured wrong in Subversion?



More information about the webkit-reviews mailing list