[webkit-reviews] review requested: [Bug 3905] Missing </title>
makes page blank : [Attachment 6753] Patch v4
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Feb 26 22:08:32 PST 2006
David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked for review:
Bug 3905: Missing </title> makes page blank
http://bugzilla.opendarwin.org/show_bug.cgi?id=3905
Attachment 6753: Patch v4
http://bugzilla.opendarwin.org/attachment.cgi?id=6753&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Changes since Patch v3:
- After further review the copy constructor and assignment operator mentioned
in Comment #18 were not needed. It was sufficient to save the state simply by
using the default assignment operator in HTMLTokenizer::parseTag().
- Moved the code in HTMLParser::parseToken() into HTMLParser::handleError()
[part 2] since that's where all the other cleanup code lives.
More information about the webkit-reviews
mailing list