[webkit-reviews] review requested: [Bug 7450] elementAtPoint is expensive and should return a smart dictionary : [Attachment 6747] Implementation using a smart dictionary (round 4)

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 7450: elementAtPoint is expensive and should return a smart dictionary
http://bugzilla.opendarwin.org/show_bug.cgi?id=7450

Attachment 6747: Implementation using a smart dictionary (round 4)
http://bugzilla.opendarwin.org/attachment.cgi?id=6747&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> We should probably import <Foundation/Foundation.h> rather than individual
Foundation headers in WebKit code.

I am under the impression it is better to include the specific header when you
subclass, and add @class ... for any other classes you need. This speeds up
compile time.

I was using CFAllocatorAllocate so we could safely use CFAllocatorDeallocate.
No longer needed if we pass NULL for the value callbacks.

I falsely assumed what capacity meant to CFDictionary based on what
NSMutableDictionary mean by dictionaryWithCapacity (as the initial size, not a
hard maximum). Corrected.