[webkit-reviews] review denied: [Bug 3905] Missing </title> makes page blank : [Attachment 6741] Patch v3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 25 20:03:53 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 3905: Missing </title> makes page blank

Attachment 6741: Patch v3

------- Additional Comments from Darin Adler <darin at apple.com>
It's not good that this code calls SegmentedString::toString() before parsing
any <title>. This undoes the SegmentedString optimization, by building a giant
string out of all the separate pieces. And it's going to happen often since
many documents have a <title> tag.

Instead, we should simply assign savedSrc to src, without calling toString. We
will presumably have to write our own copy constructor because the
m_currentChar field might be pointing to m_pushedChar1 or m_pushedChar2.

This code also relies on the assignment operator of SegmentedString working.
Since we're using the compiler-generated one in that case we could have the
same trouble, except that we're in the special case of a SegmentedString that
was just created so we know that m_currentChar is not pointing to m_pushedChar1
or 2. So I think we need to implement operator= as well for SegmentedString.

This copy constructor and assignment operator should not be too terribly
difficult, since m_currentChar is the only case where I think we need to do
anything special.

More information about the webkit-reviews mailing list