[webkit-reviews] review cancelled: [Bug 3905] Missing </title> makes page blank : [Attachment 6733] Patch v2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 25 18:54:44 PST 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has cancelled David Kilzer
(ddkilzer) <ddkilzer at kilzer.net>'s request for review:
Bug 3905: Missing </title> makes page blank
http://bugzilla.opendarwin.org/show_bug.cgi?id=3905

Attachment 6733: Patch v2
http://bugzilla.opendarwin.org/attachment.cgi?id=6733&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Changes since Patch v2:

- Added a test for an unclosed <title> tag in the <body>, which failed with
Patch v1 and v2.
- Added code to HTMLParser::parseToken() to handle condition when no </title>
tag exists.  Patch v1 and v2 handled this implicitly (probably in
HTMLParser::handleError() when the </head> tag was processed) for the first
case (missing </title> in <head>), but not for the second case (in the <body>).



More information about the webkit-reviews mailing list