[webkit-reviews] review requested: [Bug 3905] Missing </title> makes page blank : [Attachment 6732] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 25 09:38:56 PST 2006

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 3905: Missing </title> makes page blank

Attachment 6732: Patch v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Patch v1 includes a layout test and code fix.

The code fix is to determine when HTMLTokenizer::parseSpecial() has consumed
the rest of the document looking for </title> from within
HTMLTokenizer::parseTag(), then reset the state of the tokenizer and retokenize
with no special handling for the title.  The HTML parser will then take care of
adding the missing </title> tag.

NOTE: I'm not sure whether the state of the tokenizer has been reset
sufficiently in this patch!  Please verify this when reviewing the patch.  I
reset 'src' and 'lineno', but didn't really look at any other state variables. 
There may be other tokenizer state variables that need to be reset!

I did run all of the layout tests and they all passed (except
fast/js/date-constructor.html which has known issues).

More information about the webkit-reviews mailing list