[webkit-reviews] review requested: [Bug 6893] REGRESSION: Major bug with TinyMCE, no value submitted from textarea : [Attachment 6695] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Feb 23 22:14:58 PST 2006


Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 6893: REGRESSION: Major bug with TinyMCE, no value submitted from textarea
http://bugzilla.opendarwin.org/show_bug.cgi?id=6893

Attachment 6695: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6695&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
This patch is described above, but also includes code to normalize line endings
coming into the textarea via pasting or drag and drop.	I also renamed
m_valueIsValid to m_valueMatchesRenderer, because I think that makes its
meaning clearer.  I am currently working on a set of automated tests, and will
post those shortly.  

Yes this code will be blown away soon, but the time between now and when the
new textarea implementation is landed is too long to let this terrible bug sit
in the tree (and 10.4.5) imo.



More information about the webkit-reviews mailing list