[webkit-reviews] review denied: [Bug 6844] elementAtPoint returns the list when the point is over a list marker : [Attachment 6656] patch

[bugzilla-request-daemon at opendarwin.org]

Justin Garcia <justin.garcia at apple.com> has denied Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 6844: elementAtPoint returns the list when the point is over a list marker
http://bugzilla.opendarwin.org/show_bug.cgi?id=6844

Attachment 6656: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6656&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
I'm clearing the review flag for now, since I need to make two changes to this
patch.	

First, If text that is inside the list item overlaps the list marker (imagine a
<span> with a negative margin inside the list item), I want nodeAtPoint to
return the text, not the list marker.  So, in RenderListItem::nodeAtPoint, I
should only call RenderListMarker::nodeAtPoint if normal hit testing fails.  

Also, since m_rect is cached at paint time, a normal layout test won't be able
to test these changes.	I'll have to pull the code that computes the size and
position of the list marker out into a separate function and make sure it's
called from nodeAtPoint if the cached rect is empty.