[webkit-reviews] review requested: [Bug 7321] REGRESSION: style tag in body causes two head elements to appear in the DOM : [Attachment 6676] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Feb 23 05:58:50 PST 2006


David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked Maciej Stachowiak
<mjs at apple.com> for review:
Bug 7321: REGRESSION: style tag in body causes two head elements to appear in
the DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=7321

Attachment 6676: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=6676&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Patch v1.  Maciej commented on IRC that he wanted to see my next patch, so I'm
giving him first dibs on the review.  :)  I assume I'll get a review- because
there is no layout test, but I'm looking for feedback on the patch and on how
to implement a layout test.

Regarding a layout test, it seems to me that a
layoutTestController.dumpDOMTree() method would be really handy for a test like
this.  Is this worth implementing, or is there a preferred method (such as
JavaScript DOM inspection) to test that the DOM has but a single HEAD node?



More information about the webkit-reviews mailing list