[webkit-reviews] review cancelled: [Bug 6933] Selection extends beyond focus ring for some contentEditable divs : [Attachment 6666] patch 2

[bugzilla-request-daemon at opendarwin.org]

Graham Dennis <Graham.Dennis at gmail.com> has cancelled Graham Dennis
<Graham.Dennis at gmail.com>'s request for review:
Bug 6933: Selection extends beyond focus ring for some contentEditable divs
http://bugzilla.opendarwin.org/show_bug.cgi?id=6933

Attachment 6666: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=6666&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Justin: I've done more to this patch than just add a space. The previous patch
was causing the following test cases to behave strangely:
editing/selection/3690703
editing/selection/3690703-2
editing/selection/3690719
They are all editable divs with tables inside. The problem was that the
editable div was being set as the selection root for the tables, whereas the
tables would previously have been set as the selection root.
In this patch, the editable div is only set to be the selection root for cases
where the root or body elements would have been the selection root. With this
patch, the previously mentioned layout tests are unchanged, but the following
are changed (as expected):
editing/selection/extend-by-word-002
editing/selection/select-all-001
editing/selection/select-all-002