[webkit-reviews] review granted: [Bug 6844] elementAtPoint returns the list when the point is over a list marker : [Attachment 6656] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 22 12:12:25 PST 2006


Dave Hyatt <hyatt at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 6844: elementAtPoint returns the list when the point is over a list marker
http://bugzilla.opendarwin.org/show_bug.cgi?id=6844

Attachment 6656: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6656&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) I'd only do this special nodeAtPoint call if your list-style-position is
outside and if hittestaction is foreground.

(2) I'd just make setInnerNode public.

Make sure you test both inside and outside markers.  Inside markers should
already work, which is why I'd make this patch only for outside markers.

(I like clearly identifying the "outside" hacks in the code, so that when we
ultimately fix them, we'll know what to patch.)



More information about the webkit-reviews mailing list