[webkit-reviews] review granted: [Bug 7384] Turn off -Wno-unused-param for JavaScriptCore and get rid of unused params : [Attachment 6659] turn on unused param warning, fix warnings

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 22 09:33:39 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7384: Turn off -Wno-unused-param for JavaScriptCore and get rid of unused
params
http://bugzilla.opendarwin.org/show_bug.cgi?id=7384

Attachment 6659: turn on unused param warning, fix warnings
http://bugzilla.opendarwin.org/attachment.cgi?id=6659&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
What I don't like about this pattern:

    (void)other

is that you can then subsequently use the "other" variable; so such a line
doesn't mean that the variable is unused, it just means that someone quieted an
unused variable warning at some point.

I much prefer the technique of leaving out the parameter because it really
*does* mean that the variable is unused.

I see the (void) technique being used here, presumably in cases where the ifdef
would be more complicated without it. I'd prefer not to use it at all.

That having been said, the patch seems fine to land. We can revisit that later.


r=me



More information about the webkit-reviews mailing list