[webkit-reviews] review requested: [Bug 7245] caret does not display at the end of some lines in contenteditable divs : [Attachment 6662] patch 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 22 04:14:01 PST 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked Justin Garcia
<justin.garcia at apple.com> for review:
Bug 7245: caret does not display at the end of some lines in contenteditable
divs
http://bugzilla.opendarwin.org/show_bug.cgi?id=7245

Attachment 6662: patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=6662&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
There was no reason why I wasn't removing the editing style when the
contentEditable attribute was set to false. I've fixed that in this patch.
Previously, the editing style was forcibly removed, overriding any style that
may have been applied (e.g. if a style of "word-wrap: break-word" was set on an
element in the HTML, it would be removed if a contentEditable attribute was
removed). In this patch, only the mapped attribute is removed, which means that
if the element has an inline style of "word-wrap: break-word" it won't be
overridden back to whatever the default is.



More information about the webkit-reviews mailing list