[webkit-reviews] review requested: [Bug 7411] Inline some fucntions Shark suggested : [Attachment 6660] patch to address comments and add a few more inlines

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 22 00:25:43 PST 2006


Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 7411: Inline some fucntions Shark suggested
http://bugzilla.opendarwin.org/show_bug.cgi?id=7411

Attachment 6660: patch to address comments and add a few more inlines
http://bugzilla.opendarwin.org/attachment.cgi?id=6660&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Yes, removing operator= altogether is just as well. No, put() does not inline,
nor do some other virtuals my first patch inlined. (Also explains why I
couldn't get processFuncDecl to inline. That was driving me crazy.)

New patch addresses both issues and adds a few more inlines (which is why I'm
asking for review again). Total speedup: 2.9%.



More information about the webkit-reviews mailing list