[webkit-reviews] review granted: [Bug 7330] baselinePosition is wrong for new text field when empty : [Attachment 6652] new patch w/ changelog & tests

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 21 15:16:16 PST 2006


Dave Hyatt <hyatt at apple.com> has granted Adele Peterson <adele at apple.com>'s
request for review:
Bug 7330: baselinePosition is wrong for new text field when empty
http://bugzilla.opendarwin.org/show_bug.cgi?id=7330

Attachment 6652: new patch w/ changelog & tests
http://bugzilla.opendarwin.org/attachment.cgi?id=6652&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) Can remove the elses in the chain of ifs, since they're all just returning
anyway.

(2) Need to add in paddingTop() as well as borderTop().

(3) Add a testcase that tests padding-top.

r=me



More information about the webkit-reviews mailing list