[webkit-reviews] review denied: [Bug 6933] Selection extends beyond
focus ring for some contentEditable divs : [Attachment 6457] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Feb 21 14:21:22 PST 2006
Justin Garcia <justin.garcia at apple.com> has denied Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 6933: Selection extends beyond focus ring for some contentEditable divs
http://bugzilla.opendarwin.org/show_bug.cgi?id=6933
Attachment 6457: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6457&action=edit
------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
We changed our coding style guidelines, the * now belongs adjacent to the type,
instead of the identifier.
The FIXME above the code you added concerns me. You'll return true for a table
that is the root editable element, maybe you should return false if isTable()
at the start of this function.
Optional suggestion:
Instead of getting element() over and over, you could get it once and put it
into a local variable.
More information about the webkit-reviews
mailing list