[webkit-reviews] review denied: [Bug 7398] Crash in setFocusNode if the old focus node has been detached : [Attachment 6637] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 20 23:02:17 PST 2006


Darin Adler <darin at apple.com> has denied Graham Dennis
<Graham.Dennis at gmail.com>'s request for review:
Bug 7398: Crash in setFocusNode if the old focus node has been detached
http://bugzilla.opendarwin.org/show_bug.cgi?id=7398

Attachment 6637: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6637&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch looks good. We need a layout test for regression-testing purposes and a
change log entry.

Also, did you run all the other layout tests to check that this didn't break
anything?



More information about the webkit-reviews mailing list