[webkit-reviews] review granted: [Bug 7331] CSS parser leaks when parsing incorrect CSS : [Attachment 6593] patch, including change log

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 20 17:30:59 PST 2006


Eric Seidel <macdome at opendarwin.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 7331: CSS parser leaks when parsing incorrect CSS
http://bugzilla.opendarwin.org/show_bug.cgi?id=7331

Attachment 6593: patch, including change log
http://bugzilla.opendarwin.org/attachment.cgi?id=6593&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks great.  Went over it in person.  One error found with 
-    m_stylesheetDoc = 0;
in
 void XSLStyleSheetImpl::clearDocuments()

We'll also need to make sure we performance test before landing.

r=me.



More information about the webkit-reviews mailing list