[webkit-reviews] review cancelled: [Bug 7123] Caret leaves contenteditable region when it reaches the edge : [Attachment 6594] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 20 02:57:20 PST 2006


Graham Dennis <Graham.Dennis at gmail.com> has cancelled Graham Dennis
<Graham.Dennis at gmail.com>'s request for review:
Bug 7123: Caret leaves contenteditable region when it reaches the edge
http://bugzilla.opendarwin.org/show_bug.cgi?id=7123

Attachment 6594: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6594&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
While moving the common code into a function, I noticed a bug in my previous
patch. If the node for either the new position or the old position was NULL,
then the code would seg-fault. The new function checks for this possibility.



More information about the webkit-reviews mailing list