[webkit-reviews] review denied: [Bug 5753] Image ALT tags do not appear : [Attachment 6595] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 18 22:01:34 PST 2006

Darin Adler <darin at apple.com> has denied Karl Schramm <karlfschramm at mac.com>'s
request for review:
Bug 5753: Image ALT tags do not appear

Attachment 6595: patch

------- Additional Comments from Darin Adler <darin at apple.com>
There's code here to draw the alt text "above the error image".

So never drawing the error image, while it might make the alt text appear, is
not quite doing what the existing code expects. In fact, if we're going to
remove this feature of drawing both an error image and alt text, then we should
probably change the function and remove the errorPictureDrawn code from the alt
text code path.

I don't think should be landed until we understand why the "above the error
image" code path isn't kicking in.

More information about the webkit-reviews mailing list