[webkit-reviews] review requested: [Bug 7123] Caret leaves contenteditable region when it reaches the edge : [Attachment 6594] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 18 17:55:58 PST 2006


Graham Dennis <Graham.Dennis at gmail.com> has asked Justin Garcia
<justin.garcia at apple.com> for review:
Bug 7123: Caret leaves contenteditable region when it reaches the edge
http://bugzilla.opendarwin.org/show_bug.cgi?id=7123

Attachment 6594: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6594&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
Patch
When adjusting the selection forward or backward by a character, we check that
the rootEditableElement of the old position is the same as the new one. We
don't need to worry about word or paragraph granularities, as that is all
handled by nextBoundary/previousBoundary in visible_units.cpp (the only case
not handled by next/previousBoundary is a granularity of character).



More information about the webkit-reviews mailing list