[webkit-reviews] review granted: [Bug 7345] add insert and remove functions to KXMLCore::Vector : [Attachment 6591] implementation of insert and remove

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 18 15:02:58 PST 2006


Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7345: add insert and remove functions to KXMLCore::Vector
http://bugzilla.opendarwin.org/show_bug.cgi?id=7345

Attachment 6591: implementation of insert and remove
http://bugzilla.opendarwin.org/attachment.cgi?id=6591&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The ASSERT in remove() should be <, not <=. Other than that, r=me.



More information about the webkit-reviews mailing list