[webkit-reviews] review granted: [Bug 3230] CSS1: Words with inline elements get extra capital letters : [Attachment 6471] Proposed patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Feb 18 06:40:42 PST 2006


Darin Adler <darin at apple.com> has granted Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 3230: CSS1: Words with inline elements get extra capital letters
http://bugzilla.opendarwin.org/show_bug.cgi?id=3230

Attachment 6471: Proposed patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=6471&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think it's OK to land this now. I don't like the name "runOnString" for a
boolean that means "has a previous character is not a space", but those are
nitpicks and this seems fine.

Dave had told me this is a difficult area to get right, but on his previous
review he only mentioned the two issues that were investigated and fixed so I'm
going to assume all is well.

r=me



More information about the webkit-reviews mailing list