[webkit-reviews] review denied: [Bug 5146] max-height/max-width not resizing images with correct aspect ratio : [Attachment 6526] patch 5

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has denied Sam Weinig <sam.weinig at gmail.com>'s
request for review:
Bug 5146: max-height/max-width not resizing images with correct aspect ratio
http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

Attachment 6526: patch 5
http://bugzilla.opendarwin.org/attachment.cgi?id=6526&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Everything looks fine except for this section:

@@ -1216,15 +1213,15 @@ int RenderBox::calcReplacedWidthUsing(Wi
     else
	 w = style()->maxWidth();
     
-    switch (w.type) {
+    switch (w.type)
+    {
     case Fixed:
	 return calcContentBoxWidth(w.value);
-    case Percent: {
+    case Percent: 
	 const int cw = containingBlockWidth();
	 if (cw > 0)
	     return calcContentBoxWidth(w.minWidth(cw));
-    }
-    // fall through
+    //fall through
     default:
	 return intrinsicWidth();
     }

You changed things here to no long match our style guidelines.	Can you just
undo that section and re-attach the patch? Thanks!