[webkit-reviews] review requested: [Bug 7245] caret does not display at the end of some lines in contenteditable divs : [Attachment 6564] patch

[bugzilla-request-daemon at opendarwin.org]

Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 7245: caret does not display at the end of some lines in contenteditable
divs
http://bugzilla.opendarwin.org/show_bug.cgi?id=7245

Attachment 6564: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6564&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
This problem is caused by the contentEditable styling not being applied for
elements which do not have a renderer when setContentEditable() is called on
the root element. This bug is not present in Mail.app as the HTML body is set
editable programmatically once the renderers exist. The check is in
applyEditingStyleToElement, and is used to check that the element that the
editing style is being applied to has a renderer that is a BlockFlow. However,
this check doesn't make sense (to me) as although the root contentEditable
element may not be a BlockFlow, elements that inherit the style from it may be.

My solution is to simply remove the BlockFlow check (and the renderer check).