[webkit-reviews] review denied: [Bug 7227] REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab : [Attachment 6528] a better patch!

[bugzilla-request-daemon at opendarwin.org]

Justin Garcia <justin.garcia at apple.com> has denied Vicki Murley
<vicki at apple.com>'s request for review:
Bug 7227: REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order
differs for mouse click and tab
http://bugzilla.opendarwin.org/show_bug.cgi?id=7227

Attachment 6528: a better patch!
http://bugzilla.opendarwin.org/attachment.cgi?id=6528&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
Shouldn't all of the value() methods const?  They don't modify any member
variables.

Why do you refuse to fire onChange if the textfield/area is empty?  Imagine
removing all the text from a textfield that contains "foo" as its defaultValue
and then tabbing out.  onChange should fire, but it wouldn't after your change.


It sounds like other browsers only fire onChange if the text hasn't changed
from the time that that textfield/area was focused.  If that's the case then
you'll need to store the value of the textfield/area at the time that the
textfield/area was focused.