[webkit-reviews] review requested: [Bug 5146] max-height/max-width not resizing images with correct aspect ratio : [Attachment 6526] patch 5

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 15 21:02:11 PST 2006


Sam Weinig <sam.weinig at gmail.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 5146: max-height/max-width not resizing images with correct aspect ratio
http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

Attachment 6526: patch 5
http://bugzilla.opendarwin.org/attachment.cgi?id=6526&action=edit

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
In this latest version of the patch, I've cleaned up the changes and tried to
focus them into RenderImage as to avoid unintended side effects with
RenderReplaced.  There is still no functionality for absolutly positioned
images.  I've also added more test cases to more accuratly show all of the
changes.



More information about the webkit-reviews mailing list