[webkit-reviews] review requested: [Bug 6452] KIO::appendEscapingBadChars() doesn't know about %u-escaping. : [Attachment 6486] don't escape % characters

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 14 12:21:52 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 6452: KIO::appendEscapingBadChars() doesn't know about %u-escaping.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6452

Attachment 6486: don't escape % characters
http://bugzilla.opendarwin.org/attachment.cgi?id=6486&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
I don't really see how to check all code paths that end up in
appendEscapingBadChars()... There is a regression test included in the patch,
and "everything else" still seems to work fine - which is admittedly less than
a perfect evidence.



More information about the webkit-reviews mailing list