[webkit-reviews] review denied: [Bug 6890] SVG - invalid polyline
data causes hang : [Attachment 6464] fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Feb 14 03:21:27 PST 2006
Eric Seidel <macdome at opendarwin.org> has denied Alexander Kellett
<lypanov at mac.com>'s request for review:
Bug 6890: SVG - invalid polyline data causes hang
http://bugzilla.opendarwin.org/show_bug.cgi?id=6890
Attachment 6464: fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6464&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A couple comments:
1. I think it's better to declare optr on its own line. (make the declaration
less confusing).
2. I think optr deserves a better name. Honestly, I think ptr deserves a
better name... The code is hard enough to read as is... giving the variables
cryptic names only hurts :(
3. While you're in there, you might as well remove the commented out
//std::cout lines.
Three little nits, if you were landing your own patches you could just fix them
as you landed, but since someone else has to land this, I think it's best to
get one more round of patches.
More information about the webkit-reviews
mailing list