[webkit-reviews] review denied: [Bug 7145] Report error during PostScript conversion via delegate : [Attachment 6381] Patch v2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Feb 10 08:48:35 PST 2006

John Sullivan <sullivan at apple.com> has denied David D. Kilzer
<ddkilzer at kilzer.net>'s request for review:
Bug 7145: Report error during PostScript conversion via delegate

Attachment 6381: Patch v2

------- Additional Comments from John Sullivan <sullivan at apple.com>
I actually meant a code comment, but I'm grateful for the detailed explanation
in the bug. Now that there's a WebKit error with a nice precise name, I don't
think a code comment is necessary anymore.

In the block where you set up  the error, there's no reason to have a local
variable for webView.

Since you've introduced a new localizable string, you need to run the script
update-webkit-localizable-strings (in WebKitTools/Scripts/) to update the
Localizable.strings file. Otherwise the new string won't appear in the user
interface (or be localizable). This makes me wonder how you tested the new
error -- did you look in Safari's Activity window to see if the error string
appeared? I would expect it not to since Localizable.strings wasn't updated.

More information about the webkit-reviews mailing list