[webkit-reviews] review denied: [Bug 7148] Add drag and drop support to DumpRenderTree : [Attachment 6363] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Feb 10 08:30:23 PST 2006

Darin Adler <darin at apple.com> has denied Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 7148: Add drag and drop support to DumpRenderTree

Attachment 6363: patch

------- Additional Comments from Darin Adler <darin at apple.com>
If a page is not a test in itself, you should put it in a resources
subdirectory. That way the test script won't generate separate results for the

If updateFocusState is now SPI, can we remove the _setWindowHasFocus: and
_setDisplaysWithFocusAttributes: SPI? Also, why doesn't
setDisplaysWithFocusAttributes: call updateFocusState?

I don't think it's a good technique to have DumpRenderTree pose as WebHTMLView.
We do that with AppKit classes because we don't have any alternative, but since
DumpRenderTree and WebHTMLView are both part of WebKit, we can expose whatever
we need as SPI or API instead of doing the "pose" thing. For example, we could
have an SPI delegate method on the UI delegate to start drags. But I suppose we
could land it with the posing if that's significantly easier to write.

This otherwise looks pretty good.

More information about the webkit-reviews mailing list