[webkit-reviews] review requested: [Bug 3400] setting the .src of an iframe to the same value does not reload page : [Attachment 6369] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Feb 9 14:02:26 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 3400: setting the .src of an iframe to the same value does not reload page
http://bugzilla.opendarwin.org/show_bug.cgi?id=3400

Attachment 6369: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6369&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Making tests wasn't exactly straightforward because of bugs like 7161, 3609 and
3580, but here they are :)

I couldn't come up with a new name for updateForNewURL(), but getting rid of
this function by moving its code into setLocation() appears to be a better
thing to do anyway.



More information about the webkit-reviews mailing list