[webkit-reviews] review denied: [Bug 7145] Report error during PostScript conversion via delegate : [Attachment 6357] Patch v1

[bugzilla-request-daemon at opendarwin.org]

John Sullivan <sullivan at apple.com> has denied David D. Kilzer
<ddkilzer at kilzer.net>'s request for review:
Bug 7145: Report error during PostScript conversion via delegate
http://bugzilla.opendarwin.org/show_bug.cgi?id=7145

Attachment 6357: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=6357&action=edit

------- Additional Comments from John Sullivan <sullivan at apple.com>
This looks like the right approach.

The NSError doesn't need to be released, because it is returned from
_webKitErrorWithDomain:code:URL: as an autoreleased object.

WebKitErrorCannotShowURL seems like the best choice of the existing WebKit
errors, but I agree that it's not quite appropriate. We should invent a new
error code just for this case. We can't modify WebKitErrors.h without API
approval, so a new error would have to be added to WebKitErrorsPrivate.h.

Please add a comment explaining under what circumstances this conversion could
fail. Also, please attach at least one test file to this bug that causes the
error to occur.