[webkit-reviews] review denied: [Bug 6830] Outline auto is not
cleared correctly for non-rectangular outlines : [Attachment
6241] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Feb 8 23:17:28 PST 2006
Dave Hyatt <hyatt at apple.com> has denied Graham Dennis
<Graham.Dennis at gmail.com>'s request for review:
Bug 6830: Outline auto is not cleared correctly for non-rectangular outlines
http://bugzilla.opendarwin.org/show_bug.cgi?id=6830
Attachment 6241: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6241&action=edit
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) You have to do this even in the case where the topOverflow of the line is <
0, so you can't just return r along the block code path in that case without
adding this code too.
(2) In the block case, continuations are irrelevant. You can remove that piece
of the code.
More information about the webkit-reviews
mailing list