[webkit-reviews] review requested: [Bug 7145] Report error during PostScript conversion via delegate : [Attachment 6357] Patch v1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 8 21:47:25 PST 2006


David D. Kilzer <ddkilzer at kilzer.net> has asked John Sullivan
<sullivan at apple.com> for review:
Bug 7145: Report error during PostScript conversion via delegate
http://bugzilla.opendarwin.org/show_bug.cgi?id=7145

Attachment 6357: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=6357&action=edit

------- Additional Comments from David D. Kilzer <ddkilzer at kilzer.net>
First pass at a patch.	I'm pretty sure I'll need a different NSError, but this
code at least shows the URL in the Activity Window.

Also, I wasn't sure whether the NSError needed to be released.	When I tried to
release it, the Activity Window would either cause a Bus Error or just not show
up (with an error logged to the Terminal window where I started WebKit+Safari).


See Attachment 6314 from Bug 3527 for an invalid PostScript file to test with.



More information about the webkit-reviews mailing list