[webkit-reviews] review denied: [Bug 3400] setting the .src of an iframe to the same value does not reload page : [Attachment 6349] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 8 18:48:57 PST 2006


Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 3400: setting the .src of an iframe to the same value does not reload page
http://bugzilla.opendarwin.org/show_bug.cgi?id=3400

Attachment 6349: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6349&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's clear that this change will affect only the handling of the location and
src attributes of frame and iframe objects. That's good, so I think the change
is fine. I think that we might also want to rename the updateForNewURL function
to clarify that it can be used even when the URL is not changing.

It should be straightforward to make a test for this, using the onload handler
for the frame element. We'd want to test both location and src for both frames
and iframes. Setting review- just because we need the test.



More information about the webkit-reviews mailing list