[webkit-reviews] review denied: [Bug 3527] Allow Safari to open postscript files in browser windows as well : [Attachment 6313] Patch v4

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 7 09:50:51 PST 2006

Darin Adler <darin at apple.com> has denied David D. Kilzer
<ddkilzer at kilzer.net>'s request for review:
Bug 3527: Allow Safari to open postscript files in browser windows as well

Attachment 6313: Patch v4

------- Additional Comments from Darin Adler <darin at apple.com>
This is looking great, but not quite ready to land.


Despite my earlier request that we report this error somehow, it's not
appropriate for WebKit to put up an alert directly. We don't know what use the
WebView is being put to -- for example it could be used entirely off-screen. So
it's not appropriate to present an alert directly to the user.

Also, if we did want to present the alert directly to the user we'd need to
localize the strings using UI_STRING.

I suggest making a version of the patch without the alert and landing it that
way. We can discuss further handling of the error after landing the initial

Sorry for leading you astray with my earlier comment about error handling.


+	 data = [self convertPostScriptDataSourceToPDF:[dataSource data]];

This line should say:

+	 data = [self convertPostScriptDataSourceToPDF:data];

More information about the webkit-reviews mailing list