[webkit-reviews] review granted: [Bug 7107] Refactor Date object to provide direct access to milliseconds/offset : [Attachment 6294] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Feb 6 18:18:56 PST 2006


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 7107: Refactor Date object to provide direct access to milliseconds/offset
http://bugzilla.opendarwin.org/show_bug.cgi?id=7107

Attachment 6294: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6294&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+static bool isTime_tSigned()
+{
+    time_t minusOne = (time_t)(-1);
+    return minusOne < 0;
+}

The above function should be marked inline, because if so it will act as a
compile-time constant.

If tested thoroughly, looks good, r=me.



More information about the webkit-reviews mailing list