[webkit-reviews] review granted: [Bug 7117] Add support for Win32
GIF rendering. : [Attachment 6308] The remaining changes to
existing image code (as well as a lame version of Timer for Win32).
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Feb 6 18:13:45 PST 2006
Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 7117: Add support for Win32 GIF rendering.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7117
Attachment 6308: The remaining changes to existing image code (as well as a
lame version of Timer for Win32).
http://bugzilla.opendarwin.org/attachment.cgi?id=6308&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ if (strlen(aString)) {
More efficient to check aString[0] instead of calling strlen.
- if (strcasecmp (operatorString, compositeOperators[i].name) == 0)
{
+ if (strcmp(aString, compositeOperators[i].name) == 0) {
Why is it OK to do this case-sensitive now?
+struct _cairo_surface;
+typedef struct _cairo_surface cairo_surface_t;
Don't need that first separate struct line in C++.
More information about the webkit-reviews
mailing list