[webkit-reviews] review requested: [Bug 7107] Refactor Date object to provide direct access to milliseconds/offset : [Attachment 6294] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7107: Refactor Date object to provide direct access to milliseconds/offset
http://bugzilla.opendarwin.org/show_bug.cgi?id=7107

Attachment 6294: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6294&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
While refactoring the code, I had to also make several Windows-specific
changes.

Apparently, the Windows _daylight global has a different meaning than seems to
have been expected by GetTimezoneOffset implementation. In fact, _daylight is
non-zero if the machine is configured to support daylight savings time, not
when DST is active. In other words, there are two ways to make _daylight
non-zero:
1) Tick "Automatically adjust clock for daylight saving changes" checkbox in
Date and Time control panel - _daylight becomes 1 (the actual value is
undocumented).
2) give TZ environment variable a value that includes a DST timezone. E.g.:
set TZ=MSK3  -> _daylight=0
set TZ=MSK3MSD	-> _daylight=77 (value depends on the timezone, also
undocumented).