[webkit-reviews] review requested: [Bug 3527] Allow Safari to open postscript files in browser windows as well : [Attachment 6279] Patch v3

[bugzilla-request-daemon at opendarwin.org]

David D. Kilzer <ddkilzer at kilzer.net> has asked  for review:
Bug 3527: Allow Safari to open postscript files in browser windows as well
http://bugzilla.opendarwin.org/show_bug.cgi?id=3527

Attachment 6279: Patch v3
http://bugzilla.opendarwin.org/attachment.cgi?id=6279&action=edit

------- Additional Comments from David D. Kilzer <ddkilzer at kilzer.net>
Updates for this patch (ignore comments for Patch v2):

- Consolidated code changes to one class--WebPDFRepresentation.m.
- Added a number of ASSERT()s (too many?).
- Removed commented-out code.
- Changed 'NULL' to '0'.
- Added releases for converter, provider, consumer.
- Set result to autorelease.
- Switched from using NSMutableData * to CFMutableDataRef.

Finally, I'm not sure what should happen if CGPSConverterConvert() fails.  The
ASSERT(success) will throw some kind of assertion exception, I suppose.