[webkit-reviews] review denied: [Bug 7012] Coerce javascript objects to appleScript compatible types prior to returning them to applescript : [Attachment 6223] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has denied Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 7012: Coerce javascript objects to appleScript compatible types prior to
returning them to applescript
http://bugzilla.opendarwin.org/show_bug.cgi?id=7012

Attachment 6223: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6223&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
The patch looks good, only a few minor details.

I would fall back to always returning a string in the "default" case instead of
the "Unknown JavaScript type: %d", jsValue->type()" error, unless this is never
reached.

The WebView.h header can't be changed until we get the API approved. You will
need to use WebViewPrivate.h for this interface.