[webkit-reviews] review granted: [Bug 5776] REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not calculated right : [Attachment 6214] Proposed patch 4

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Feb 3 09:30:07 PST 2006


Darin Adler <darin at apple.com> has granted Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 5776: REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not
calculated right
http://bugzilla.opendarwin.org/show_bug.cgi?id=5776

Attachment 6214: Proposed patch 4
http://bugzilla.opendarwin.org/attachment.cgi?id=6214&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Great! r=me

I noticed a RenderObject * that should be RenderObject*, and I don't think
making the list parameter to previousListItemElement is good, since it means
you search for the list twice if there is none. But both of those are so minor
they are no obstacle to landing this.

Very nice tests.



More information about the webkit-reviews mailing list