[webkit-reviews] review requested: [Bug 5776] REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not calculated right : [Attachment 6206] Proposed patch 3

[bugzilla-request-daemon at opendarwin.org]

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 5776: REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not
calculated right
http://bugzilla.opendarwin.org/show_bug.cgi?id=5776

Attachment 6206: Proposed patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=6206&action=edit

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
- Use traversePreviousNode to traverse tree in a nicer way
- Move DOM node looking code to the render tree
- Remove calculation of start nodes from html_listimpl.cpp. Only explicitly set
values are set from here now.
- Rename functions: previousListItemElement and enclosingList
- Did not change attach() to use a function to find the enclosing list as that
function was moved to render_list.cpp
- List items with styles that won't display a number still get assigned an
invisible number (remove LNONE check that came from original code). This
matches every other browser I tried including IE and Firefox.